Re: [Xen-devel] [PATCH for-4.12] vpci: reduce verboseness of BAR write warnings

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.02.19 at 17:53, <roger.pau@xxxxxxxxxx> wrote:
> On Mon, Feb 18, 2019 at 09:45:07AM -0700, Jan Beulich wrote:
>> >>> On 18.02.19 at 17:24, <roger.pau@xxxxxxxxxx> wrote:
>> > @@ -381,6 +371,19 @@ static void bar_write(const struct pci_dev *pdev, 
>> > unsigned int reg,
>> >      else
>> >          val &= PCI_BASE_ADDRESS_MEM_MASK;
>> >  
>> > +    if ( pci_conf_read16(pdev->seg, pdev->bus, slot, func, PCI_COMMAND) &
>> > +         PCI_COMMAND_MEMORY )
>> > +    {
>> > +        /* If the value written is the current one avoid printing a 
>> > warning. */
>> > +        if ( val != (uint32_t)(bar->addr >> (hi ? 32 : 0)) )
>> > +            gprintk(XENLOG_WARNING,
>> > +                    "%04x:%02x:%02x.%u: ignored BAR %lu write with memory 
>> > decoding enabled\n",
>> > +                    pdev->seg, pdev->bus, slot, func,
>> > +                    bar - pdev->vpci->header.bars + (hi ? 1 : 0));
>> 
>> Why the conditional operator? bool converts fine to an integer
>> value of 0 or 1.
> 
> Hm, I always forget about this. Would you be willing to fix this at
> commit if Juergen gives it his RAB?

Sure.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel