Re: [Xen-devel] [PATCH v2] x86/pv: Fix construction of 32bit dom0's

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Feb 14, 2019 at 04:49:21AM -0700, Jan Beulich wrote:
> >>> On 14.02.19 at 12:10, <wei.liu2@xxxxxxxxxx> wrote:
> > From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > 
> > dom0_construct_pv() has logic to transition dom0 into a compat domain when
> > booting an ELF32 image.
> > 
> > One aspect which is missing is the CPUID policy recalculation, meaning that 
> > a
> > 32bit dom0 sees a 64bit policy, which differ by the Long Mode feature flag 
> > in
> > particular.  Another missing item is the x87_fip_width initialisation.
> > 
> > Update dom0_construct_pv() to use switch_compat(), rather than retaining the
> > opencoding.  Position the call to switch_compat() such that the compat32 
> > local
> > variable can disappear entirely.
> > 
> > The 32bit monitor table is now created by setup_compat_l4(), avoiding the 
> > need
> > to for manual creation later.  Furthermore, the L3 table creation is 
> > redundant
> > with the logic inside the main mapping loop, so can be dropped as well.
> 
> This last sentence is no longer applicable afaict.

Good catch.

I think the subject line also needs fixing. It should read:

    x86/pv: Fix construction of 32bit dom0

i.e. the possessive form is wrong.

> 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> With that line dropped
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel