Re: [Xen-devel] [RFC PATCH 2/6] tools/libxc: Define VM_EVENT type

[Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>]

On Tue, 2019-01-08 at 09:25 -0700, Jan Beulich wrote:
> > > > On 19.12.18 at 19:52, <ppircalabu@xxxxxxxxxxxxxxx> wrote:
> > 
> > @@ -796,7 +787,7 @@ struct xen_domctl_gdbsx_domstatus {
> >   * EXDEV  - guest has PoD enabled
> >   * EBUSY  - guest has or had paging enabled, ring buffer still
> > active
> >   */
> > -#define XEN_DOMCTL_VM_EVENT_OP_PAGING            1
> > +#define XEN_VM_EVENT_TYPE_PAGING         1
> 
> Assuming the renaming is for the purpose of re-use elsewhere,
> I think these should be moved to vm_event.h then.

I will move the definitions to vm_event.h but part of the corresponding
comments will have to remain in domctl.h (e.g. XEN_VM_EVENT_ENABLE
error codes for each vm_event type).
> 
> > + * This hypercall allows one to control the vm_event rings
> > (enable/disable),
> > + * as well as to signal to the hypervisor to pull responses
> > (resume) and
> > + * retrieve the event channel from the given ring.
> > + */
> > +#define XEN_VM_EVENT_ENABLE               0
> > +#define XEN_VM_EVENT_DISABLE              1
> > +#define XEN_VM_EVENT_RESUME               2
> 
> Same perhaps for these, albeit here you just move them down a
> few lines.
These are the actual XEN_DOMCTL_vm_event_op opcodes. They are used only
in conjunction with this domctl so I would prefer not to move them.

Many thanks for your comments,
Petre


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel