Re: [Xen-devel] [PATCH for-4.12] x86/svm: Fix handling of ICEBP intercepts

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.02.19 at 20:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 04/02/2019 09:16, Jan Beulich wrote:
>>>>> On 01.02.19 at 18:09, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> A subsequent #DB getting raised causes #GP to turn into #DF.
>> The table on the #DF page clearly says
>> otherwise, at least according to my reading.
> 
> Hmm - so it does.  Looks like we've got a 3rd bug, in the general
> exception combining logic.

I've sent a patch. I'd like to note though that svm_inject_event()'s
behavior is problematic in this regard as well: Fiddling with RIP and
NEXTRIP without knowing whether a second exception may
replace the first is at least a latent issue. I think any such
adjustments should only ever be done at the point no further
need for exception injection can possibly arise, i.e. presumably in
svm_vmenter_helper().

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel