Re: [Xen-devel] [OSSTEST PATCH 5/5] power: ssh: Wait for the target to appear to go down

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Jan 25, 2019 at 02:50:46PM +0000, Ian Jackson wrote:
> When we `power on' with the ssh method, we actually run ssh reboot.
> 
> On some systems (notably, FreeBSD) the kernel does not simply reboot
> immediately even with the runes we provide here, ie for FreeBSD
>   reboot -nq
> Eg, I have seen reboots with several messages like this:
>   Jan 25 14:17:59.100044 Waiting (max 60 seconds) for system thread 
> `bufspacedaemon-2' to stop... done

So it seems like reboot -nq doesn't behave as expected...

> This can result in the ssh method failing spuriously, because the
> `power on' appears to complete while the host is still up in the
> previous environment.  In one of my test runs I saw an ssh to the host
> succeed, and print the uptime (of the existing environment), between
> the reboot command being issued and the host actually rebooting.
> 
> So, wait (up to just over a minute) until the host does not respond to
> ping.  (target_await_down runs ping -c 5.)
> 
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel