Re: [Xen-devel] [PATCH v3 7/7] xen/dom0: Add a dom0-iommu=none option

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.01.19 at 10:00, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -709,6 +709,12 @@ Controls for the dom0 IOMMU setup.
>      This option is enabled by default on x86 systems, and invalid on ARM
>      systems.
>  
> +*   The `none` option is intended for development purposes only, and skips
> +    certain safety checks pertaining to the correct IOMMU configuration for
> +    dom0 to boot.

Would you mind inserting "PVH" ahead of "dom0"?

> @@ -156,7 +159,7 @@ int iommu_domain_init(struct domain *d)
>  
>  static void __hwdom_init check_hwdom_reqs(struct domain *d)
>  {
> -    if ( !paging_mode_translate(d) )
> +    if ( iommu_hwdom_none || !paging_mode_translate(d) )
>          return;

Seeing the __hwdom_init, wouldn't it be better to restrict this
relaxation to Xen boot time created Dom0?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel