Re: [Xen-devel] [PATCH] tools/firmware: update OVMF Makefile

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Jan 13, 2019 at 09:17:44PM +0100, Olaf Hering wrote:
> On Wed, Nov 28, Wei Liu wrote:
> 
> > OVMF has become dependent on OpenSSL, which it is included as a submodule.
> > Initialise submodules before building.
> 
> > +++ b/tools/firmware/ovmf-makefile
> >  build:
> > +   $(GIT) submodule update --init --recursive
> 
> At least ef529e6ab7c31290a33045bb1f1837447cc0eb56 seems to have no
> submodules. Also the referenced qemu-xen.git has submodules, but
> building xen.git works fine if none of the download-on-demand extra
> sources are actually git trees. I have not checked how qemu-xen.git
> would get its submodules, but today there is most likely no
> "$(GIT) submodule" call in the "build" make target.

QEMU's Makefile calls a script which calls git submodule commands.

Calling `git submodule update` in a git repo without submodules is a
nop.

> 
> I think to fix the build breakage introduced by b16281870 this call must
> be moved somewhere else.

Can you tell me what build breakage are you referring to? The latest
osstest flight (131927) didn't show any breakage in building.

Are you saying that the breakage is shown when you put a snapshot of
ovmf under xen.git? How does ovmf distribute their snapshot? How is that
generated? Does it contain snapshots of submodules it needs already?

Wei.

> 
> Olaf



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel