Re: [Xen-devel] [PATCH v2 2/4] x86/e820: do not fixup memmap in copy_e820_map

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.12.18 at 13:04, <roger.pau@xxxxxxxxxx> wrote:
> @@ -510,6 +496,12 @@ static void __init reserve_dmi_region(void)
>      }
>  }
>  
> +static void __init reserve_vga_region(void)
> +{
> +    /* Remove any RAM regions from the VGA hole. */
> +    e820_remove_range(&e820, KB(640), MB(1) - 1, E820_RAM, true);

From looking at patch 1 I got the impression that the "end" parameter
is exclusive. If that's not intended to be that way, then there may
be further issues with the use of < / <= / > / >= .

I'm also unconvinced of this getting put in a separate function.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel