Re: [Xen-devel] [PATCH] libxl: get_reaper_lock_and_uid: Document fd handling

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On Jan 2, 2019, at 10:03 PM, Ian Jackson <ian.jackson@xxxxxxxxxxxxx> wrote:
> 
> Coverity understandably complains that get_reaper_lock_and_uid leaks
> the fd and hence open-file.  But this is intentional: the lock becomes
> owned by the child process as a whole, which is entirely the property
> of libxl.
> 
> (The coding style here in this subprocess is a bit anomalous but it's
> probably not worth it to convert get_reaper_lock_and_uid to `goto out'
> style and have it explicitly return the fd number.)
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel