Re: [Xen-devel] status of non-live migration of HVM with libvirt

[Olaf Hering <olaf@xxxxxxxxx>]

Am Fri, 4 Jan 2019 16:57:55 +0100
schrieb Olaf Hering <olaf@xxxxxxxxx>:

> worth keeping (and fixing) the concept of an "offline migration"

And regarding the fix, it looks like qmp_xen_save_devices_state does not need 
the concept of "live". Just shutdown the blockdevices and be done with it?

+++ b/migration/savevm.c
@@ -2293,7 +2293,7 @@ void qmp_xen_save_devices_state(const char *filename, 
bool has_live, bool live,
          * So call bdrv_inactivate_all (release locks) here to let the other
          * side of the migration take controle of the images.
          */
-        if (live && !saved_vm_running) {
+        if (!saved_vm_running) {
             ret = bdrv_inactivate_all();
             if (ret) {
                 error_setg(errp, "%s: bdrv_inactivate_all() failed (%d)",


Olaf

Attachment: pgpSRswynJryd.pgp
Description: Digitale Signatur von OpenPGP

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel