Re: [Xen-devel] [PATCH 3/4] docs/man: Fix/simplify generation of manpages

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Andrew Cooper writes ("[PATCH 3/4] docs/man: Fix/simplify generation of 
manpages"):
> The DOC_MANx lists are broken.  They contain MANxSRC-y twice, the first half
> with a partial %.pod substituation, and the second half with a partial
> %.markdown substitution.  This is also the root cause behind the filtering
> activity in the uninstall-man$(i)-pages rule.
...
> As for the makefile:
> 
> 1) Break the MAN_SECTIONS list out of the GENERATE_MANPAGE_RULES loop, as we
>    are going to use it a second time.
> 2) Do away with the individaul MANxSRC-y variables.  Use a single list,
>    derived from all *.pod and *.pandoc files, with their format suffixes
>    removed.
> 3) Use a $(foreach ...) to generate the DOC_MANx lists, filling them with the
>    correct content.
> 4) The DOC_HTML and DOC_TXT can now include all manpages with a single
>    substitution, as they don't need to separate the manpages by
>    section-numbered-directory.
> 5) Fix up the filenames in the manpage metarule to match the renaming.
> 
> No functional change.

How confident are you that this does not break -j-safety ?
I very briefly eyeballed it and nothing jumped out at me.  I wonder
if I should review it properly.  What do you think ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel