Re: [Xen-devel] [PATCH for-4.12 v2 3/8] xen/arm: Rename p2m_map_foreign to p2m_map_foreign_rw

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 20 Dec 2018, Julien Grall wrote:
> A follow-up patch will introduce another type of foreign mapping. Rename
> the type to make clear it is only used for read-write mapping.
> 
> No functional changes intended.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
>     Changes in v2:
>         - Add Andrii's reviewed-by
> ---
>  xen/arch/arm/mm.c         | 2 +-
>  xen/arch/arm/p2m.c        | 2 +-
>  xen/include/asm-arm/p2m.h | 6 +++---
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index d96a6655ee..7193d83b44 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1267,7 +1267,7 @@ int xenmem_add_to_physmap_one(
>          }
>  
>          mfn = page_to_mfn(page);
> -        t = p2m_map_foreign;
> +        t = p2m_map_foreign_rw;
>  
>          rcu_unlock_domain(od);
>          break;
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index cd34149d13..e0b84a9db5 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -467,7 +467,7 @@ static void p2m_set_permission(lpae_t *e, p2m_type_t t, 
> p2m_access_t a)
>          break;
>  
>      case p2m_iommu_map_rw:
> -    case p2m_map_foreign:
> +    case p2m_map_foreign_rw:
>      case p2m_grant_map_rw:
>      case p2m_mmio_direct_dev:
>      case p2m_mmio_direct_nc:
> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
> index 4db8e8709d..a1aef7b793 100644
> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -115,7 +115,7 @@ typedef enum {
>      p2m_mmio_direct_dev,/* Read/write mapping of genuine Device MMIO area */
>      p2m_mmio_direct_nc, /* Read/write mapping of genuine MMIO area 
> non-cacheable */
>      p2m_mmio_direct_c,  /* Read/write mapping of genuine MMIO area cacheable 
> */
> -    p2m_map_foreign,    /* Ram pages from foreign domain */
> +    p2m_map_foreign_rw, /* Read/write RAM pages from foreign domain */
>      p2m_grant_map_rw,   /* Read/write grant mapping */
>      p2m_grant_map_ro,   /* Read-only grant mapping */
>      /* The types below are only used to decide the page attribute in the P2M 
> */
> @@ -137,10 +137,10 @@ typedef enum {
>  
>  /* Useful predicates */
>  #define p2m_is_ram(_t) (p2m_to_mask(_t) & P2M_RAM_TYPES)
> -#define p2m_is_foreign(_t) (p2m_to_mask(_t) & p2m_to_mask(p2m_map_foreign))
> +#define p2m_is_foreign(_t) (p2m_to_mask(_t) & 
> p2m_to_mask(p2m_map_foreign_rw))
>  #define p2m_is_any_ram(_t) (p2m_to_mask(_t) &                   \
>                              (P2M_RAM_TYPES | P2M_GRANT_TYPES |  \
> -                             p2m_to_mask(p2m_map_foreign)))
> +                             p2m_to_mask(p2m_map_foreign_rw)))
>  
>  /* All common type definitions should live ahead of this inclusion. */
>  #ifdef _XEN_P2M_COMMON_H
> -- 
> 2.11.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel