Re: [Xen-devel] [PATCH 7/9] libxl: Make killing of device model asynchronous

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

George Dunlap writes ("[PATCH 7/9] libxl: Make killing of device model 
asynchronous"):
> Or at least, give it an asynchronous interface so that we can make it
> actually asynchronous in subsequent patches.
> 
> Create state structures and callback function signatures.  Add the
> state structure to libxl__destroy_domid_state.  Break
> libxl__destroy_domid down into two functions.
...
> +/* Used to detroy the device model */
> +_hidden void libxl__destroy_device_model(libxl__egc *egc,
> +                                         libxl__destroy_devicemodel_state 
> *ddms);

I think that comment is rather pointless (but I won't object if you
really want to keep it).  Conversely it would be nice to say somewhere
that ddms->callback may be called reentrantly.

Everything else LGTM.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel