Re: [Xen-devel] [PATCH 8/9] libxl: Kill QEMU by uid when possible

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, Nov 23, 2018 at 05:18:59PM +0000, George Dunlap wrote:
> On 11/23/18 5:15 PM, George Dunlap wrote:
> Does libxl__qmp_cleanup() need to be called after the kill() happens?
> If not, we could put this before the kill() and avoid having two call sites.

QEMU is supposed to create monitor sockets before the guest is running,
even before it drops priviledge, so I don't think it matter when we `rm`
those qmp sockets. There are only useful to libxl anyway, once libxl
don't needs them they can be removed.

So, before kill() should be fine.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel