Re: [Xen-devel] [PATCH v2 2/3] xen: remove tmem from hypervisor

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Nov 28, 2018 at 02:47:32PM +0000, Wei Liu wrote:
> On Wed, Nov 28, 2018 at 07:43:25AM -0700, Jan Beulich wrote:
> > >>> On 28.11.18 at 14:58, <wei.liu2@xxxxxxxxxx> wrote:
> > > @@ -250,7 +249,7 @@ static void populate_physmap(struct memop_args *a)
> > >  
> > >                  if ( unlikely(!page) )
> > >                  {
> > > -                    if ( !tmem_enabled() || a->extent_order )
> > > +                    if ( a->extent_order )
> > >                          gdprintk(XENLOG_INFO,
> > >                                   "Could not allocate order=%u extent: 
> > > id=%d memflags=%#x (%u of %u)\n",
> > >                                   a->extent_order, d->domain_id, 
> > > a->memflags,
> > 
> > From an abstract pov without tmem tmem_enabled() should return constant
> > "false". Which seems to mean that the if() should go away rather than its
> > condition getting changed.
> 
> Ack.

BTW there is another hunk in this patch which should get the same treatment:

@@ -2265,7 +2231,7 @@ int assign_pages(                                         
                                                                              
     {                                                                          
                                                                              
         if ( unlikely((d->tot_pages + (1 << order)) > d->max_pages) )          
                                                                              
         {                                                                      
                                                                              
-            if ( !tmem_enabled() || order != 0 || d->tot_pages != d->max_pages 
)                                                                             
+            if ( order != 0 || d->tot_pages != d->max_pages )                  
                                                                              
                 gprintk(XENLOG_INFO, "Over-allocation for domain %u: "         
                                                                              
                         "%u > %u\n", d->domain_id,                             
                                                                              
                         d->tot_pages + (1 << order), d->max_pages);      

I will fix it as well.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel