Re: [Xen-devel] [PATCH v2] mm: make opt_bootscrub non-init

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Nov 27, 2018 at 03:25:29PM +0100, Roger Pau Monné wrote:
> On Tue, Nov 27, 2018 at 03:13:27AM -0700, Jan Beulich wrote:
> > >>> On 26.11.18 at 18:55, <roger.pau@xxxxxxxxxx> wrote:
> > > --- a/xen/common/page_alloc.c
> > > +++ b/xen/common/page_alloc.c
> > > @@ -166,7 +166,14 @@ enum bootscrub_mode {
> > >      BOOTSCRUB_ON,
> > >      BOOTSCRUB_IDLE,
> > >  };
> > > -static enum bootscrub_mode __initdata opt_bootscrub = BOOTSCRUB_IDLE;
> > > +/*
> > > + * opt_bootscrub should live in the init section, since it's not accessed
> > > + * afterwards. However at least LLVM assumes there are no side effects of
> > > + * accessing the variable, and optimizes the condition so opt_bootscrub 
> > > is
> > 
> > ... the condition in init_heap_pages() ...
> > 
> > (which I guess can be folded in while committing).
> 
> Yes please.
> 

I have fixed this and taken the liberty to add a blank line before this
comment block.

Wei.

> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel