[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4.9 and older] VMX: allow migration of guests with SSBD enabled


  • To: Jan Beulich <JBeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Mon, 26 Nov 2018 01:08:24 +0000
  • Accept-language: en-US
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
  • Delivery-date: Mon, 26 Nov 2018 01:08:32 +0000
  • Dlp-product: dlpe-windows
  • Dlp-reaction: no-action
  • Dlp-version: 11.0.400.15
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHUgwavyXMlLJMn/UWts3lOq7NjmKVhQtMA
  • Thread-topic: [PATCH 4.9 and older] VMX: allow migration of guests with SSBD enabled

> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Friday, November 23, 2018 4:30 PM
> 
> The backport of cd53023df9 ("x86/msr: Virtualise MSR_SPEC_CTRL.SSBD for
> guests to use") did not mirror the PV side change into the HVM (VMX-
> specific) code path.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>

> 
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -978,7 +981,8 @@ static int vmx_load_msr(struct vcpu *v,
>               * ignored) when STIBP isn't enumerated in hardware.
>               */
>              else if ( ctxt->msr[i].val &
> -                      ~(SPEC_CTRL_IBRS | SPEC_CTRL_STIBP) )
> +                      ~(SPEC_CTRL_IBRS | SPEC_CTRL_STIBP |
> +                        (v->domain->arch.cpuid->feat.ssbd ? SPEC_CTRL_SSBD : 
> 0)) )
>                  err = -ENXIO;
>              else
>                  v->arch.spec_ctrl = ctxt->msr[i].val;
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.