Re: [Xen-devel] [PATCH v3] tools: set Dom0 UUID if requested

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Nov 23, 2018 at 04:25:00PM +0000, Wei Liu wrote:
> On Fri, Nov 23, 2018 at 04:18:41PM +0000, Wei Liu wrote:
> > On Fri, Nov 23, 2018 at 03:28:49PM +0000, Anthony PERARD wrote:
> > > > diff --git a/tools/hotplug/Linux/systemd/xen-init-dom0.service.in 
> > > > b/tools/hotplug/Linux/systemd/xen-init-dom0.service.in
> > > > index 3befadcea3..beed3126c6 100644
> > > > --- a/tools/hotplug/Linux/systemd/xen-init-dom0.service.in
> > > > +++ b/tools/hotplug/Linux/systemd/xen-init-dom0.service.in
> > > > @@ -7,8 +7,9 @@ ConditionPathExists=/proc/xen/capabilities
> > > >  [Service]
> > > >  Type=oneshot
> > > >  RemainAfterExit=true
> > > > +EnvironmentFile=@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons
> > > >  ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
> > > > -ExecStart=@LIBEXEC_BIN@/xen-init-dom0
> > > > +ExecStart=@LIBEXEC_BIN@/xen-init-dom0 $XEN_DOM0_UUID
> > > >  
> > > >  [Install]
> > > >  WantedBy=multi-user.target
> > > 
> > > Don't you need to modify FreeBSD/rc.d/xencommons.in and
> > > NetBSD/rc.d/xencommons.in as well?
> > 
> > I didn't want to modify them without having a test setup first.  The
> > xen-init-dom0 program already takes into consideration that they don't
> > provide UUID.
> > 
> > I can do it in the next version.
> 
> Actually, now I remember. They don't have the same mechanism as Linux to
> source a system wide config file, so modifying the script without fixing
> that issue made no sense to me.
> 
> Roger, what's your opinion?

I think it's fine to leave them as-is. Since there's no configuration
file for BSDs init scripts modifying them to add such parameter is
pointless.

If you feel like I guess you could add a placeholder to set the UUID
in the init script itself, but that's more like a hack since users are
not supposed to modify such scripts.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel