Re: [Xen-devel] [PATCH] common: make sure symbols-dummy.o gets rebuilt when needed

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.11.18 at 16:30, <wei.liu2@xxxxxxxxxx> wrote:
> On Thu, Nov 22, 2018 at 03:47:41AM -0700, Jan Beulich wrote:
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -100,9 +100,6 @@ prelink.o: $(ALL_OBJS)
>>      $(LD) $(LDFLAGS) -r -o $@ $^
>>  endif
>>  
>> -$(BASEDIR)/common/symbols-dummy.o:
>> -    $(MAKE) -f $(BASEDIR)/Rules.mk -C $(BASEDIR)/common symbols-dummy.o
>> -
>>  $(TARGET)-syms: prelink.o xen.lds $(BASEDIR)/common/symbols-dummy.o
> 
> As discussed on IRC direct dependencies on symbols-dummy.o should be
> deleted.

I'll drop them, but I'm having trouble seeing how their presence
would break things. We recurse into common/ normally anyway.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel