Re: [Xen-devel] [PATCH 01/14] x86/soft-reset: Drop gfn reference after calling get_gfn_query()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.11.18 at 14:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> get_gfn_query() internally takes the p2m lock, and this error path leaves it
> locked.
> 
> This wasn't included in XSA-277 because the error path can only be triggered
> by a carefully timed phymap operation concurrent with the domain being paused
> and the toolstack issuing DOMCTL_soft_reset.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

You could have retained my
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
from when this was still part of the XSA-277 patch itself.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel