Re: [Xen-devel] [PATCH v6 03/11] libxl_qmp: Change qmp_qemu_check_version to compare version

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Nov 22, 2018 at 12:24:29PM +0000, Anthony PERARD wrote:
> On Mon, Nov 12, 2018 at 05:22:45PM +0000, Ian Jackson wrote:
> > Anthony PERARD writes ("[PATCH v6 03/11] libxl_qmp: Change 
> > qmp_qemu_check_version to compare version"):
> > > This patch makes the function simpler to read. It also add the ability
> > > for a caller to tell if QEMU is newer or have the exact version.
> > 
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> I will add the following to the document to clarify when a callback can
> be called (not synchronously).
> 
> +++ b/tools/libxl/libxl_internal.h
> @@ -388,5 +388,6 @@ struct libxl__ev_child {
>   * libxl__ev_qmp_send: Idle/Connected -> Active (on error: Idle)
>   *    Sends a command to QEMU.
>   *    callback will be called when a response is received or when an
>   *    error as occured.
> + *    callback isn't called synchronously.
>   *

That was meant for the next patch: "libxl: Design of an async API to
issue QMP commands to QEMU" ... (which is acked as well).

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel