Re: [Xen-devel] [PATCH] x86/p2m: constify p2m_mem_access_sanity_check()

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 11/21/18 1:52 PM, George Dunlap wrote:
> On 11/21/18 11:41 AM, Jan Beulich wrote:
>>>>> On 21.11.18 at 12:03, <george.dunlap@xxxxxxxxxx> wrote:
>>> On 11/21/18 11:01 AM, Razvan Cojocaru wrote:
>>>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>>>
>>> Why?
>>
>> Are you asking in general (I think it's obvious), or merely because
>> the commit description is empty?
> 
> I didn't see that you had suggested it as a trivial improvement.
> 
> I agree it's a minor improvement, but normally such improvements don't
> come in out of the blue: they're done in order to achieve some goal (for
> example, to allow this function to be called from another function that
> only has a const pointer).  Recording the motivation is important; I'd
> argue that recording the lack of motivation is important as well (so
> that people don't go looking for one that isn't there).

I'll resend the patch with a small description.
Also, I should have added a Suggested-by tag that would have clearly
helped in this case, my mistake.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel