Re: [Xen-devel] [PATCH 3/3] xen-init-dom0: set Dom0 UUID if requested

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Wei Liu writes ("[PATCH 3/3] xen-init-dom0: set Dom0 UUID if requested"):
> Read from XEN_CONFIG_DIR/dom0-uuid. If it contains a valid UUID, set
> it for Dom0.

I approve of the basic principle of this change.  Thanks.

However, I am not particularly keen on the details of the config
representation.

> +dom0-uuid           - stores the UUID in canonical form for Dom0, will be
> +                      read by xen-init-dom0

The parsing approach taken means this file
  - may not contain leading comments
  - may contain ignore trailing stuff
  - is not read completely

Wouldn't it be better to put this in the global xl configuration ?

Ie, call xlu_cfg_init, xl_cfg_readdata, and xlu_cfg_get_string ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel