Re: [Xen-devel] [PATCH 4/3] x86/HVM: hvm_map_guest_frame_rw() should respect p2m_ioreq_server

[Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>]

On 13/11/2018 10:46, Jan Beulich wrote:
> Writes to such pages would need to be handed to the emulator, which we're
> not prepared to do at this point.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2556,7 +2556,8 @@ static void *_hvm_map_guest_frame(unsign
>  
>      if ( writable )
>      {
> -        if ( unlikely(p2m_is_discard_write(p2mt)) )
> +        if ( unlikely(p2m_is_discard_write(p2mt)) ||
> +             unlikely(p2mt == p2m_ioreq_server) )

Shouldn't we introduce p2m_is_ioreq_server() for consistency and use it
everywhere?

Igor

>              *writable = 0;
>          else if ( !permanent )
>              paging_mark_pfn_dirty(d, _pfn(gfn));
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel