Re: [Xen-devel] [PATCH 2/3] tools: No longer advertise GIT_HTTP env var

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:ian.jackson@xxxxxxxxxxxxx]
> Sent: 05 November 2018 18:43
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Paul Durrant
> <Paul.Durrant@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>
> Subject: [PATCH 2/3] tools: No longer advertise GIT_HTTP env var
> 
> In "build: add autoconf to replace custom checks in tools/check"
> --enable-githttp was introduced.  But we missed this comment where it
> was advertised.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Paul Durrant <paul.durrant@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>

TBH I'd squash this into the previous patch. I think it's better to modify the 
comment at the same time as the behaviour.

  Paul

> ---
>  config/Tools.mk.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index d5985c0d09..98245f63c9 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -40,7 +40,7 @@ XEN_TOOLS_RPATH     := @rpath@
>  # Download GIT repositories via HTTP or GIT's own protocol?
>  # GIT's protocol is faster and more robust, when it works at all
> (firewalls
>  # may block it). We make it the default, but if your GIT repository
> downloads
> -# fail or hang, please specify GIT_HTTP=y in your environment.
> +# fail or hang, please pass --enable-githttp to configure.
>  GIT_HTTP            ?= @githttp@
> 
>  # Optional components
> --
> 2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel