Re: [Xen-devel] [OSSTEST PATCH] ts-xen-build: Force reliance on ipxe tarball

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:ian.jackson@xxxxxxxxxxxxx]
> Sent: 05 November 2018 18:36
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Paul Durrant
> <Paul.Durrant@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>
> Subject: [OSSTEST PATCH] ts-xen-build: Force reliance on ipxe tarball
> 
> xen.git/tools/firmware/etherboot/Makefile tries to get a tarball from
> xen-extfiles first and if that fails, tries cloning from ipxe.org.
> 
> ipxe.org is sometimes down (or half-down) and when that happens
> without a tarball the build breaks and is hard to fix.
> 
> We would like, therefore, to ensure that the tarball is always made
> before the commit which refers to it is in xen.git#master.
> 
> osstest has no knowledge of ipxe as a separate thing and just lets
> xen.git have whatever version is in Config.mk.  So osstest never needs
> to specify particular ipxe version by hash, or the like.
> 
> So simply make osstest rely on the tarball existing, by having it
> specify a completely invalid URL for the git clone.  This will detect
> attempts to update IPXE_GIT_TAG without making a corresponding
> tarball.
> 
> CC: Paul Durrant <paul.durrant@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  ts-xen-build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ts-xen-build b/ts-xen-build
> index 48bf062f..6ddfc533 100755
> --- a/ts-xen-build
> +++ b/ts-xen-build
> @@ -95,6 +95,7 @@ sub checkout () {
>       echo >>.config debug=$debug_build
>       echo >>.config GIT_HTTP=y
>       echo >>.config LIBLEAFDIR_x86_64=lib
> +     echo >>.config IPXE_GIT_URL=file:////osstest/IPXE-GIT-FORBIDDEN

Do you really need four '/'? I thought three would be enough for a FQPN. Since 
it's supposed to be an invalid URL though it doesn't really matter...

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

>       echo >>.config KERNELS=''
>  END
>                 (${enable_livepatch} ? <<END : '').
> --
> 2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel