Re: [Xen-devel] [RFC 13/16] xen/arm: p2m: Allow to flush cache on any RAM region

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Mon, 8 Oct 2018, Julien Grall wrote:
> Currently, we only allow to flush cache on region mapped as p2m_ram_{rw,ro}.
                                             ^ regions

> There are no real problem to flush cache on any RAM region such as grants
                    ^ problems in cache flushing any RAM regions


> and foreign mapping. Therefore, relax the cache to allow flushing the
                                            ^ check


> cache on any RAM region.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

Aside from grammar:

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

> ---
>  xen/arch/arm/p2m.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 8537b7bab1..12b459924b 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1532,7 +1532,7 @@ int p2m_cache_flush_range(struct domain *d, gfn_t 
> start, gfn_t end)
>          next_gfn = gfn_next_boundary(start, order);
>  
>          /* Skip hole and non-RAM page */
> -        if ( mfn_eq(mfn, INVALID_MFN) || !p2m_is_ram(t) )
> +        if ( mfn_eq(mfn, INVALID_MFN) || !p2m_is_any_ram(t) )
>              continue;
>  
>          /* XXX: Implement preemption */
> -- 
> 2.11.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel