Re: [Xen-devel] [RFC PATCH v2 12/17] xenconsoled: make console_type->use_gnttab less confusing

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Marek Marczykowski-Górecki writes ("[RFC PATCH v2 12/17] xenconsoled: make 
console_type->use_gnttab less confusing"):
> Before this commit 'use_gnttab' means xenconsoled should first try
> special GNTTAB_RESERVED_CONSOLE entry, and only then fallback to
> ring-ref xenstore entry (being gfn of actual ring).
> In case of secondary consoles, ring-ref entry contains grant table
> reference (not gfn of it), which makes the old meaning of use_gnttab
> really confusing (should be false for such consoles).
> To solve this, add new entry in console_type (and console) structures
> named 'use_reserverd_gnttab' with the old meaning of 'use_gnttab', then
> use 'ues_gnttab' for consoles where ring-ref holds grant table
> reference.

I'm afraid I don't have the mental bandwidth to deal with this patch
properly right now but if you change the meaning of `use_gnttab' you
should certainly rename it.  Otherwise you risk failing to update some
part of the code for the new semantics.

Also, I feel I'm being dim, but I don't understand what combinations
of your (new) use_gnttab and use_reserved_gnttab are legitimate and
what their meanings are.  Maybe this wants to be one enum instead of
two booleans.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel