Re: [Xen-devel] [PATCH] libxl/arm: fix guest type conversion

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Nov 01, 2018 at 10:26:16AM +0000, Julien Grall wrote:
> Hi Wei,
> 
> On 01/11/2018 08:59, Wei Liu wrote:
> > On Wed, Oct 31, 2018 at 08:16:52PM +0000, Julien Grall wrote:
> > > Hi Wei,
> > > 
> > > On 10/31/18 2:25 PM, Wei Liu wrote:
> > > > Commit 359970fd8b ("tools/libxl: Switch Arm guest type to PVH") missed
> > > > changing the type field in c_info. This issue didn't surface until
> > > > ef72c93df9 which made creating PV guest on Arm unusable.
> > > > 
> > > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > > ---
> > > > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > > > Cc: Julien Grall <julien.grall@xxxxxxx>
> > > > 
> > > > Julien, can you give this a quick test? Put type='pv' in your Arm
> > > > guest xl cfg and note the difference before and after this patch.
> > > 
> > > I tested on arm64 with and without the patch:
> > > 
> > > Tested-by: Julien Grall <julien.grall@xxxxxxx>
> > > 
> > > > 
> > > > This should fix libvirt breakage.
> > > > ---
> > > >    tools/libxl/libxl_create.c | 10 ++++++++++
> > > >    1 file changed, 10 insertions(+)
> > > > 
> > > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> > > > index 4bb750e951..311957f87c 100644
> > > > --- a/tools/libxl/libxl_create.c
> > > > +++ b/tools/libxl/libxl_create.c
> > > > @@ -35,6 +35,16 @@ int libxl__domain_create_info_setdefault(libxl__gc 
> > > > *gc,
> > > >            return ERROR_INVAL;
> > > >        }
> > > > +#if defined(__arm__) || defined(__aarch64__)
> > > > +    if (c_info->type == LIBXL_DOMAIN_TYPE_PV) {
> > > > +        LOG(WARN, "Converting PV guest to PVH.");
> > > > +        LOG(WARN, "Arm guest are now PVH.");
> > > > +        LOG(WARN, "Please fix your configuration file/toolstack.");
> > > 
> > > We now end up to have this message printed twice.
> > 
> > I thought we need some logging so I copied them here.
> 
> I think we can remove this logging if we rely on c_info->type == b_info->type.

I will change the logging in libxl_arm.c.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel