Re: [Xen-devel] [PATCH v5 25/25] xen/arm: split domain_build.c

[Julien Grall <julien.grall@xxxxxxx>]

On 10/23/18 3:03 AM, Stefano Stabellini wrote:
> domain_build.c is too large.
>
> Move all the ACPI specific device tree generating functions from
> domain_build.c to acpi/domain_build.c.
>
> Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
>
> ---
>
> Changes in v4:
> - rename acpi_dt_build to domain_build.c
> - add copyright header
> - remove useless #include
> - remove acpi_dt_build.h, add domain_build.h
> ---
>   xen/arch/arm/acpi/Makefile         |   1 +
>   xen/arch/arm/acpi/domain_build.c   | 592 +++++++++++++++++++++++++++++++++++++
>   xen/arch/arm/domain_build.c        | 585 +-----------------------------------
>   xen/include/asm-arm/domain_build.h |  31 ++
>   4 files changed, 629 insertions(+), 580 deletions(-)
>   create mode 100644 xen/arch/arm/acpi/domain_build.c
>   create mode 100644 xen/include/asm-arm/domain_build.h
>
> diff --git a/xen/arch/arm/acpi/Makefile b/xen/arch/arm/acpi/Makefile
> index 23963f8..94ae249 100644
> --- a/xen/arch/arm/acpi/Makefile
> +++ b/xen/arch/arm/acpi/Makefile
> @@ -1,2 +1,3 @@
>   obj-y += lib.o
> +obj-y += domain_build.o
>   obj-y += boot.init.o
> diff --git a/xen/arch/arm/acpi/domain_build.c b/xen/arch/arm/acpi/domain_build.c
> new file mode 100644
> index 0000000..44d3ad1
> --- /dev/null
> +++ b/xen/arch/arm/acpi/domain_build.c
> @@ -0,0 +1,592 @@
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
I was about to ack the patch when I noticed the license is not correct 
here. This is GPLv2+ license while Xen is GPLv2 only. I know that some 
of Xen code contain such license, but this is not the case for 
domain_build.c. As there as no copyright license, we should then assume 
GPLv2.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel