[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/1] tools/ocaml: Re-introduce Xenctrl.with_intf wrapper
> On 30 Oct 2018, at 17:01, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote: > > Well, yes, but who would ever call it ? It's not safe to use except > at the toplevel (whatever that means, but probably outside any > with_intf) because elsewhere you don't know whose work you're > sabotaging. > > Which reminds me: why do you say it is wrong to use both > interface_open and with_intf ? It's clumsy and probably a mistake but > it should function correctly I think. > I agree that it would not harm but conceptually I believe you should manage this explicitly using interface_{open/close} or implicitly using with_intf. I would use an exit handler to close this global handle but it would be safe to never close it and to let the process terminate. I said “should not” rather than “must not” for that reason. Maybe that is subtle. — C _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |