Re: [Xen-devel] [PATCH v2 2/7] x86/hvm: introduce a define for the debug output IO port

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Oct 29, 2018 at 10:51:07AM -0600, Jan Beulich wrote:
> >>> On 19.10.18 at 17:20, <roger.pau@xxxxxxxxxx> wrote:
> > No functional change intended.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one remark:
> 
> > --- a/xen/include/public/arch-x86/xen.h
> > +++ b/xen/include/public/arch-x86/xen.h
> > @@ -346,6 +346,12 @@ struct xen_arch_domainconfig {
> >  #define XEN_CPUID          XEN_EMULATE_PREFIX "cpuid"
> >  #endif
> >  
> > +/*
> > + * Debug console IO port, also called "port E9 hack". Each character 
> > written
> > + * to this IO port will be printed on the hypervisor console.
> > + */
> > +#define XEN_HVM_DEBUGCONS_IOPORT 0xe9
> 
> Perhaps amend the comment with "..., subject to log level
> restrictions"? Easily done while committing.

Yes, that seems sensible, feel free to add it during commit.

> FTR I'm a little uneasy about adding this to the public
> interface, but otoh external components already use it as
> if it was part of it.

Given the current usage I think this should be part of the public
headers.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel