[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 5/5] RFC: test/depriv: Add a tool to check process-level depriv
George Dunlap writes ("[PATCH 5/5] RFC: test/depriv: Add a tool to check process-level depriv"): > Add a tool to check whether the various process-level deprivileging > operations have actually taken place on the process. ... > NB that a number of other requested changes (such as using `set -e`, > changing the output, &c) have not been made, while I consider whether > to leave this as a stand-alone script, or whether to merge osstest's > fd checker functionality into it (perhaps changing the language to perl > at the same time). OK. But, unfortunately, it is very hard to review a shell script that is written without `set -e'. Generally a big focus of my usual review style is error handling. Also, I suggested some refactoring. Seeing the script as it is makes it more obvious that a systematic approach to printing FAILED etc. would be a good idea. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |