Re: [Xen-devel] [PATCH] x86/efi: Do not insert timestamps in efi files

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.10.18 at 15:45, <bwiedemann@xxxxxxx> wrote:
> in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good.

But is this something everyone wants, unconditionally? I'm
generally happy to have this basic indication of when a certain
image was built; I regret that ELF images have no such
indication.

> --- a/Config.mk
> +++ b/Config.mk
> @@ -151,6 +151,14 @@ export XEN_HAS_BUILD_ID=y
>  build_id_linker := --build-id=sha1
>  endif
>  
> +ld-ver-timestamp = $(shell $(1) -mi386pep --no-insert-timestamp 2>&1 | \
> +                             grep -q no-insert-timestamp && echo n || echo y)
> +ifeq ($(call ld-ver-timestamp,$(LD)),n)
> +ld_no_insert_timestamp :=
> +else
> +ld_no_insert_timestamp := --no-insert-timestamp
> +endif

Irrespective of build_id_linker also living here - is this the
right place? And can't you simplify things by using the
common list model, i.e. populate ld_no_insert_timestamp-$(...)
and ...

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -157,7 +157,7 @@ note.o: $(TARGET)-syms
>       rm -f $@.bin
>  
>  EFI_LDFLAGS = $(patsubst -m%,-mi386pep,$(LDFLAGS)) --subsystem=10
> -EFI_LDFLAGS += --image-base=$(1) --stack=0,0 --heap=0,0 --strip-debug
> +EFI_LDFLAGS += --image-base=$(1) --stack=0,0 --heap=0,0 --strip-debug 
> $(ld_no_insert_timestamp)

... use $(ld_no_insert_timestamp-y) here?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel