[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 11/18] xen: get memory map from hypervisor for PVH


  • To: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
  • From: Juergen Gross <jgross@xxxxxxxx>
  • Date: Fri, 19 Oct 2018 17:06:38 +0200
  • Autocrypt: addr=jgross@xxxxxxxx; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb
  • Cc: hans@xxxxxxxxxxx, grub-devel@xxxxxxx, xen-devel@xxxxxxxxxxxxx, phcoder@xxxxxxxxx
  • Delivery-date: Fri, 19 Oct 2018 15:06:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Openpgp: preference=signencrypt

On 19/10/2018 14:40, Daniel Kiper wrote:
> On Tue, Oct 09, 2018 at 01:03:10PM +0200, Juergen Gross wrote:
>> Retrieve the memory map from the hypervisor and normalize it to contain
>> no overlapping entries and to be sorted by address.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>>  grub-core/kern/i386/xen/pvh.c | 98 
>> +++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 98 insertions(+)
>>
>> diff --git a/grub-core/kern/i386/xen/pvh.c b/grub-core/kern/i386/xen/pvh.c
>> index c1b1cf8db..b4933b454 100644
>> --- a/grub-core/kern/i386/xen/pvh.c
>> +++ b/grub-core/kern/i386/xen/pvh.c
>> @@ -22,7 +22,16 @@
>>  #include <grub/mm.h>
>>  #include <grub/i386/cpuid.h>
>>  #include <grub/xen.h>
>> +#include <grub/i386/linux.h>
>>  #include <grub/machine/kernel.h>
>> +#include <xen/memory.h>
>> +
>> +struct xen_machine_mmap_entry
>> +{
>> +  grub_uint64_t addr;
>> +  grub_uint64_t len;
>> +  grub_uint32_t type;
>> +} GRUB_PACKED;
> 
> Could not we reuse grub_e820_mmap_entry here?

This is defined only locally in grub-core/mmap/i386/pc/mmap.c

I can move it into an appropriate header and use it here and in mmap.c

> 
>>  grub_uint64_t grub_rsdp_addr;
>>
>> @@ -30,6 +39,8 @@ static struct { char _entry[32]; } hypercall_page[128]
>>    __attribute__ ((aligned (GRUB_XEN_PAGE_SIZE)));
>>
>>  static grub_uint32_t xen_cpuid_base;
>> +static struct xen_machine_mmap_entry map[128];
> 
> A constant instead of 128? If no why 128?

I can use a macro instead.

> 
>> +static unsigned int nr_map_entries;
>>
>>  static void
>>  grub_xen_early_halt (void)
>> @@ -93,11 +104,98 @@ grub_xen_hypercall (grub_uint32_t callno, grub_uint32_t 
>> a0,
>>    return __res;
>>  }
>>
>> +static void
>> +grub_xen_sort_mmap (void)
>> +{
>> +  grub_uint64_t from, to;
>> +  unsigned int i;
>> +  struct xen_machine_mmap_entry tmp;
>> +
>> +  /* Align map entries to page boundaries. */
>> +  for (i = 0; i < nr_map_entries; i++)
>> +    {
>> +      from = map[i].addr;
>> +      to = from + map[i].len;
>> +      if (map[i].type == GRUB_MEMORY_AVAILABLE)
>> +    {
>> +      from = ALIGN_UP(from, GRUB_XEN_PAGE_SIZE);
> 
> Lack of space between macro name and "(".
> Here and below...

Okay.

> 
>> +      to = ALIGN_DOWN(to, GRUB_XEN_PAGE_SIZE);
>> +    }
>> +      else
>> +    {
>> +      from = ALIGN_DOWN(from, GRUB_XEN_PAGE_SIZE);
>> +      to = ALIGN_UP(to, GRUB_XEN_PAGE_SIZE);
>> +    }
>> +      map[i].addr = from;
>> +      map[i].len = to - from;
>> +    }


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.