[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [RFC PATCH v2 01/17] libxl: fix qemu-trad cmdline for no sdl/vnc case
Marek Marczykowski-Górecki writes ("[RFC PATCH v2 01/17] libxl: fix qemu-trad cmdline for no sdl/vnc case"): > When qemu is running in stubdomain, any attempt to initialize vnc/sdl > there will crash it (on failed attempt to load a keymap from a file). If > vfb is present, all those cases are skipped. But since > b053f0c4c9e533f3d97837cf897eb920b8355ed3 "libxl: do not start dom0 qemu > for stubdomain when not needed" it is possible to create a stubdomain > without vfb and contrary to the comment -vnc none do trigger VNC > initialization code (just skips exposing it externally). > Change the implicit SDL avoiding method to -nographics option, used when > none of SDL or VNC is enabled. > > Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx> > Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index fdd7fa3..ebe8e0c 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -475,14 +475,14 @@ static int libxl__build_device_model_args_old(libxl__gc > *gc, > if (libxl_defbool_val(vnc->findunused)) { > flexarray_append(dm_args, "-vncunused"); > } > - } else > + } else if (!sdl) > /* > * VNC is not enabled by default by qemu-xen-traditional, > - * however passing -vnc none causes SDL to not be > - * (unexpectedly) enabled by default. This is overridden by > - * explicitly passing -sdl below as required. > + * however skipping -vnc causes SDL to be > + * (unexpectedly) enabled by default. If undesired, disable graphics > at > + * all. > */ > - flexarray_append_pair(dm_args, "-vnc", "none"); > + flexarray_append(dm_args, "-nographic"); > I would welcome a patch to add the missing { } to this last if branch. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |