Re: [Xen-devel] [PATCH v5 1/2] memory_hotplug: Free pages as higher order

[Oscar Salvador <osalvador@xxxxxxxxxxxxxxxxxx>]

On Fri, Oct 05, 2018 at 01:40:05PM +0530, Arun KS wrote:
> When free pages are done with higher order, time spend on
> coalescing pages by buddy allocator can be reduced. With
> section size of 256MB, hot add latency of a single section
> shows improvement from 50-60 ms to less than 1 ms, hence
> improving the hot add latency by 60%. Modify external
> providers of online callback to align with the change.
> 
> Signed-off-by: Arun KS <arunks@xxxxxxxxxxxxxx>

Looks good to me.

Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>

Just one thing below:
  
> @@ -1331,7 +1331,7 @@ void __init __free_pages_bootmem(struct page *page, 
> unsigned long pfn,
>  {
>       if (early_page_uninitialised(pfn))
>               return;
> -     return __free_pages_boot_core(page, order);
> +     return __free_pages_core(page, order);

__free_pages_core is void, so I guess we do not need that return there.
Probably the code generated is the same though.
-- 
Oscar Salvador
SUSE L3

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel