Re: [Xen-devel] [PATCH v2 2/2] amd/iommu: remove hidden AMD inclusive mappings

["Suthikulpanit, Suravee" <Suravee.Suthikulpanit@xxxxxxx>]

Roger,

On 10/2/18 3:08 PM, Roger Pau Monne wrote:
> And just rely on arch_iommu_hwdom_init to setup the correct inclusive
> mappings as it's done for Intel.
> 
> AMD has code in amd_iommu_hwdom_init to setup inclusive mappings up to
> max_pdx, remove this since it's now a duplication of
> arch_iommu_hwdom_init. Note that AMD mapped every page with a valid
> mfn up to max_pdx, arch_iommu_hwdom_init will only do so for memory
> below 4GB, so this is a functional change for AMD.
> 
> Move the default setting of iommu_hwdom_{inclusive/reserved} to
> arch_iommu_hwdom_init since the defaults are now the same for both
> Intel and AMD.
> 
> Reported-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> ---
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> Cc: Brian Woods <brian.woods@xxxxxxx>
> Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
>   xen/drivers/passthrough/amd/pci_amd_iommu.c | 39 ---------------------
>   xen/drivers/passthrough/vtd/iommu.c         |  7 ----
>   xen/drivers/passthrough/x86/iommu.c         |  8 ++++-
>   3 files changed, 7 insertions(+), 47 deletions(-)
> 

Acked-by: Suravee Suthikulpanit <suravee.suthikupanit@xxxxxxx>

Thanks,
Suravee
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel