Re: [Xen-devel] [PATCH] Make credit2 the default scheduler

[Steven Haigh <netwiz@xxxxxxxxx>]

On 2018-09-19 19:38, Dario Faggioli wrote:
> On Sat, 2018-09-15 at 00:21 +1000, Steven Haigh wrote:
> > On Friday, 14 September 2018 6:45:35 PM AEST Jan Beulich wrote:
> > > > > >
> > > And that's despite "sched=credit2 crashes system when using
> > > cpupools"? While I agree that we shouldn't delay the switch for
> > > much longer, in particular with there already being a fix available
> > > from you I think that one should go in before the one here.
> >
> > Even though my opinion probably isn't very heavy on this matter, I've
> > used
> > credit2 exclusively for a considerable time.
> Well, this is really interesting and useful to know. Can I ask what
> your typical workload is (if any), and how are things going?
I don't really have a 'typical' workload. There's mail servers, web 
servers, DNS, shell boxes, all kinds of varied stuff. I haven't had any 
noticeable performance issues that I could look at and say "X is 
different".
> > If you're talking the issue I
> > think you're talking about, then I discovered it when doing stuff
> > that most
> > people probably wouldn't bother with - evidenced that I hadn't done
> > it before
> > either.
> Actually, we do expect the default scheduler not to crash if one
> creates a cpupool.
>
> Not that there hasn't been similar bug in Credit1, while it was the
> default (check `git log' :-/). But what this all means is that we need
> to do better at testing these things, e.g., finally adding cpupool and
> CPU online/offline testing to OSSTest.
>
> Anyway, the bugfix is in now. :-)
Agreed. I haven't had a chance to test that patch of yet - as I need to 
reconfigure the IPMI BMC to recover from a hard crash. Its tucked away 
in a rack out of sight and mind - so this isn't quite straight forward - 
but possible if I know I'm going to try and crash it :)
> > I take peoples word on the performance +/- of a few percent here and
> > there -
> > so if its easier to maintain and better code, then yeah - it makes
> > sense to
> > move on with it. I certainly haven't found any normal use cases that
> > would
> > lead me to object to this.
> Great, and thanks again for the feedback!
>
> Regards,
> Dario
--
Steven Haigh

? netwiz@xxxxxxxxx     ? http://www.crc.id.au
? +61 (3) 9001 6090    ? 0412 935 897

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel