Re: [Xen-devel] [PATCH 1/5] xentrace_format: print timestamps in nanoseconds

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Tue, 2018-09-11 at 16:54 +0100, George Dunlap wrote:
> On 09/11/2018 04:19 PM, Andrii Anisov wrote:
> > 
> > On 11.09.18 13:44, George Dunlap wrote:
> > > What I do in xenalyze is to have the timestamps in seconds, but
> > > always
> > > print down to the nanosecond.  (For this I actually break cpu
> > > cycles
> > > into s and ns separately, and then print "%u.%09u".)
> > 
> > Here, we can have the same. With the 0current formula in
> > xentrace_format, but changing `%(tsc)d` to `%(tsc).9f` in formats.
> > 
Sorry, I'm not sure I'm getting this properly. When you say "with the
current formula", do you mean before or after this series?

IAC, changing the default format file that we ship so that it prints
time in the format seconds.nanoseconds (if CPU speed is specified),
would be nice IMO.

> FYI, I never use xentrace_format; as far as I'm concerned it's been
> made
> obsolete by xenalyze, and if it were up to me I'd remove it from the
> tree.  Lots of people seem to find it useful, so I review patches.
>
I almost entirely concur. As said already, the one reason why I think
it still could be useful, and we should keep it, is that the way a
trace will look like can be changed or tweaked rather easily, and
without having to recompile anything, via the formats file, which is
rather cool. :-)

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel