Re: [Xen-devel] [PATCH] xen: Fix inconsistent callers of panic()

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 30/08/18 13:31, Andrew Cooper wrote:
> Callers are inconsistent with whether they pass a newline to panic(),
> including adjacent calls in the same function using different styles.
>
> painc() not expecting a newline is inconsistent with most other printing
> functions, which is most likely why we've gained so many inconsistencies.
>
> Switch panic() to expect a newline, and update all callers which currently
> lack a newline to include one.
>
> This actually reduces the size of .rodata (0x07e3e8 down to 0x07e3a8) because
> a number of strings are passed to both panic() and printk().  As they
> previously differed by \n alone, they couldn't be merged.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel