Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

[Olaf Hering <olaf@xxxxxxxxx>]

Am Fri, 7 Sep 2018 09:48:28 +0200
schrieb Juergen Gross <jgross@xxxxxxxx>:

> On 07/09/18 08:30, Olaf Hering wrote:
> > +   if (cpu_online(cpu))
> > +           return;
> >     if (cpu_present(cpu))
> >             xen_arch_unregister_cpu(cpu);  

> Could you merge the two if conditions?
> if (!cpu_online(cpu) && cpu_present(cpu))
>       xen_arch_unregister_cpu(cpu);

Is that any different, beside being wrong, from what the patch actually does?
It would still clear the present bit later on.

Olaf

Attachment: pgpdIdeS8KAe6.pgp
Description: Digitale Signatur von OpenPGP

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel