[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/5] x86/hvm: Misc non-functional cleanup to the HVM_PARAM infrastructure



>>> On 06.09.18 at 11:26, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
>> Sent: 05 September 2018 19:12
>> 
>> The parameter marshalling and xsm checks are common to both the set and
>> get
>> paths.  Lift all of the common code out into do_hvm_op() and let
>> hvmop_{get,set}_param() operate on struct xen_hvm_param directly.
>> 
>> This is somewhat noisy in the functions as each a. reference has to change to
>> a-> instead.
>> 
>> In addition, drop an empty default statement, insert newlines as appropriate
>> between cases, and there is no need to update the IDENT_PT on the
>> fastpath,
>> because the common path after the switch will make the update.
>> 
>> No functional change, but a net shrink of -328 to do_hvm_op().
>> 
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.