Re: [Xen-devel] [PATCH 4/6] xen/x86: Use %*pb[l] instead of cpumask_scn{, list}printf()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.18 at 14:08, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/mcheck/mce.c
> +++ b/xen/arch/x86/cpu/mcheck/mce.c
> @@ -535,9 +535,12 @@ void mcheck_cmn_handler(const struct cpu_user_regs *regs)
>              mc_panic("MCE: No CPU found valid MCE, need reset");
>          if ( !cpumask_empty(&mce_fatal_cpus) )
>          {
> -            char *ebufp, ebuf[96] = "MCE: Fatal error happened on CPUs ";
> -            ebufp = ebuf + strlen(ebuf);
> -            cpumask_scnprintf(ebufp, 95 - strlen(ebuf), &mce_fatal_cpus);
> +            char ebuf[96];
> +
> +            snprintf(ebuf, sizeof(ebuf),
> +                     "MCE: Fatal error happened on CPUs %*pd",

DYM %*pb here? With this corrected
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel