Re: [Xen-devel] [PATCH v2 6/6] x86emul: generalize vector length handling for AVX512/EVEX

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.09.18 at 13:02, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 29/08/18 15:25, Jan Beulich wrote:
>> @@ -2818,6 +2818,9 @@ x86_decode(
>>  
>>                  opcode |= b | MASK_INSR(vex.pfx, X86EMUL_OPC_PFX_MASK);
>>  
>> +                if ( !evex.mbs )
> 
> This use of mbs is very confusing to read.  How about:
> 
> #define evex_encoded evex.mbs
> 
> which at least gives a semantic name to the how you are using the mbs bit?

As you seem to think it helps, I can do that. To me the present form was
obvious enough.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel