Re: [Xen-devel] [PATCH v3] x86/hvm: remove default ioreq server

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Xen-devel [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf
> Of Jan Beulich
> Sent: 27 August 2018 14:22
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [Xen-devel] [PATCH v3] x86/hvm: remove default ioreq server
> 
> >>> On 07.08.18 at 17:42, <paul.durrant@xxxxxxxxxx> wrote:
> > My recent patch [1] to qemu-xen-traditional removes the last use of the
> > 'default' ioreq server in Xen. (This is a catch-all ioreq server that is
> > used if no explicitly registered I/O range is targetted).
> >
> > This patch can be applied once that patch is committed, to remove the
> > (>100 lines of) redundant code in Xen.
> >
> > NOTE: The removal of the special case for HVM_PARAM_DM_DOMAIN in
> >       hvm_allow_set_param() is not directly related to removal of
> >       default ioreq servers. It could have been cleaned up at any time
> >       after commit 9a422c03 "x86/hvm: stop passing explicit domid to
> >       hvm_create_ioreq_server()". It is now added to the new
> >       deprecated sets introduced by this patch.
> >
> > [1] https://lists.xenproject.org/archives/html/xen-devel/2018-
> 08/msg00270.html
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> I'm afraid this change is responsible for osstest finding
> 
> In file included from /home/osstest/build.126771.build-
> amd64/xen/tools/qemu-xen-dir/include/hw/xen/xen_backend.h:4:0,
>                  from /home/osstest/build.126771.build-amd64/xen/tools/qemu-
> xen-dir/hw/block/xen_disk.c:28:
> /home/osstest/build.126771.build-amd64/xen/tools/qemu-xen-
> dir/include/hw/xen/xen_common.h: In function
> 'xen_get_default_ioreq_server_info':
> /home/osstest/build.126771.build-amd64/xen/tools/qemu-xen-
> dir/include/hw/xen/xen_common.h:412:40: error:
> 'HVM_PARAM_BUFIOREQ_EVTCHN' undeclared (first use in this function)
>      rc = xc_get_hvm_param(xen_xc, dom,
> HVM_PARAM_BUFIOREQ_EVTCHN,
>                                         ^
> /home/osstest/build.126771.build-amd64/xen/tools/qemu-xen-
> dir/include/hw/xen/xen_common.h:412:40: note: each undeclared identifier
> is reported only once for each function it appears in
> /home/osstest/build.126771.build-amd64/xen/tools/qemu-xen-
> dir/rules.mak:69: recipe for target 'hw/block/xen_disk.o' failed
> make: *** [hw/block/xen_disk.o] Error 1
> 
> I guess I'm going to revert it for now.
> 

To unblock things, fair enough, but the code in question is protected by '#if 
CONFIG_XEN_CTRL_INTERFACE_VERSION < 40600' so I don't understand why osstest is 
hitting this.

  Paul

> Jan
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel