Re: [Xen-devel] [PATCH] xen: Improvements to domain_crash()

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 8/30/18 6:31 PM, Andrew Cooper wrote:
> There original reason for this patch was to fix a livepatching problem;
> unnecesserily large livepatchs due to the use of __LINE__.
> 
> A second problem is one of debugability.  A number of domain_crash()
> invocations have no logging at all, and number of others only have logging
> when compiled with a debug hypervisor.
> 
> Change the interface to require the caller to pass a printk() message, which
> is emitted at guest error level.  This should ensure that every time a domain
> is crashed, an informative log message is also present.
> 
> Update all callers to either merge with a previous printk(), or invent an
> informative log message.  A few select callers are switched to the
> non-printing version, when they've already emitted a relevent state dump.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel