Re: [Xen-devel] [PATCH v2 1/6] xen/arm: add THUNDERX kconfig

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 24/08/18 00:33, Stefano Stabellini wrote:
> Add a kconfig option for Cavium ThunderX platforms. >
> Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
> CC: mjaggi@xxxxxxxxxxxxxxxxxx
> CC: Zi.Lim@xxxxxxxxxx
> ---
> Changes in v2:
> - remove HAS_SMMU
> ---
>   xen/arch/arm/platforms/Kconfig  | 13 +++++++++++++
>   xen/arch/arm/platforms/Makefile |  1 +
>   2 files changed, 14 insertions(+)
>
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index 409d3f8..b9c0b7f 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -36,6 +36,16 @@ config MPSOC
>         ---help---
>         Enable all the required drivers for Xilinx Ultrascale+ MPSoC
>   
> +config THUNDERX
> +       bool "Cavium ThunderX"
> +       depends on ARM_64
> +       select GICV3
> +       select HAS_ITS
> +       select HAS_PL011
> +       select ACPI if EXPERT = "y"
Regardless what I said in the cover letter. ACPI should really not be 
selected here. It is not mandatory to use on Thunder-X and the decision 
should be left to the user.
In other words, the platform config should *only* select what is 
mandatory to run a given SoC.
To be honest, I would even consider the UART as optional because a user 
may decide it does not want any output from Xen.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel