Re: [Xen-devel] [PATCH v17 12/13] x86/hvm: Remove redundant save functions

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Aug 22, 2018 at 06:22:15PM +0300, Isaila Alexandru wrote:
> > >  
> > > -            if ( handler(d, h) != 0 )
> > > +            if ( handler(d->vcpu[0], h) != 0 )
> > >              {
> > >                  printk(XENLOG_G_ERR
> > > -                       "HVM%d save: failed to save type
> > > %"PRIu16"\n",
> > > +                       "HVM d%d save: failed to save type
> > > %"PRIu16"\n",
> > This looks like an unrelated change.
> I wanted to change this so it could be in the same order as the
> per_vcpu print that was modified at Jan's request.
> Now the print is something like:
> 
> "
> (XEN) HVM d2v0 save: CPU
> (XEN) HVM d2v1 save: CPU
> (XEN) HVM d2 save: PIC
> (XEN) HVM d2 save: IOAPIC
> (XEN) HVM d2v0 save: LAPIC
> "
> in oppose to having "(XEN) HVM2 save: PIC".
> 
> If the change is not needed I can drop it.

Just add a small comment on the commit saying that while there you
also fix the printing of a message in order to match the format of the
other save related messages.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel