Re: [Xen-devel] [PATCH] tools: libxl/xl: run NUMA placement even when an hard-affinity is set

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Dario Faggioli writes ("Re: [Xen-devel] [PATCH] tools: libxl/xl: run NUMA 
placement even when an hard-affinity is set"):
> On Mon, 2018-08-20 at 11:14 +0100, Wei Liu wrote:
> > You can use NDEBUG instead.
> 
> I found this in one other place in libxl (libxl_event.c), and figured I
> could use it here too.
> 
> Reason is that this guards a (potentially) rather expensive check,
> which I personally consider too much, even for debug build. At the same
> time, it could be handy for us developers to have it there, and be able
> to enable it when making changes to affinity and/or NUMA placement
> code.
> 
> But I don't have a too strong opinion; I'll change it to us NDEBUG if
> that's what you prefer.

Please do not use NDEBUG.  libxl is not designed to be compiled with
NDEBUG.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel